Prevent duplicate closeCallback calls in case of GC ghosts #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes PHP 7 GC decides to call stream_close again even after the PHP request has ended, and even if fclose was called before already.
1 similar comment
|
👍 good catch finally finding the cause of this issue |
|
This is only 30℅ of the cause. Thanks for merging.
|
|
Tagged 0.5.2 with this fix |
This was referenced Dec 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes PHP 7 GC decides to call stream_close again even after the
PHP request has ended, and even if fclose was called before already.
Note: the ghost is even so ghostly that you can't see it with a debugger.
Observed while debugging owncloud/core#22370 (comment)
Basically with the log statements from owncloud/core#26735 I can see that
fclosewas called and also the callback was called as well. But still, PHP somehow calls it again.After applying this fix, this specific scenario doesn't cause errors to be logged again.
@icewind1991